Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove handling of qseow-qix-perf log events from Sense #434

Closed
mountaindude opened this issue Aug 5, 2022 · 0 comments · Fixed by #437
Closed

Remove handling of qseow-qix-perf log events from Sense #434

mountaindude opened this issue Aug 5, 2022 · 0 comments · Fixed by #437
Assignees
@mountaindude
Labels
refactor General changes, not related to a specific feature or bug
Projects
Butler SOS general development
Milestone
9.2.0

Comments

@mountaindude
Copy link
Collaborator

No reason to get this data as log messages, as it's already pulled in from Sense via the healthcheck API.

Remove the (rudimentary/placeholder) code that deals with qseow-qix-perf messages.
Removing this won't make a difference as the implementation/support for this message type has not been fully implemented in Butler SOS..
@mountaindude mountaindude added this to the 9.2.0 milestone Aug 5, 2022
@mountaindude mountaindude added the refactor General changes, not related to a specific feature or bug label Aug 5, 2022
@mountaindude mountaindude self-assigned this Aug 5, 2022
@mountaindude mountaindude moved this from To do to In progress in Butler SOS general development Aug 5, 2022
mountaindude pushed a commit to mountaindude/butler-sos that referenced this issue Aug 5, 2022
refactor: Remove unnecessary handling of engine performance log messages
f05d501 
Implements ptarmiganlabs#434
@mountaindude mountaindude moved this from In progress to Done in Butler SOS general development Aug 5, 2022
@github-actions github-actions bot mentioned this issue Aug 8, 2022
Merged
This was referenced Jul 29, 2023
Closed
Closed
Closed
This was referenced Aug 16, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mountaindude mountaindude

Labels
refactor General changes, not related to a specific feature or bug
Projects
Butler SOS general development
Done
Milestone
9.2.0
1 participant
@mountaindude