fix: Don't warn for header row in Excel file when importing master items

Fixes #82
ptarmiganlabs · Oct 13, 2022 · 2ef9d0e · 2ef9d0e
1 parent 10136c8
commit 2ef9d0e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/src/ctrl-q.js b/src/ctrl-q.js
@@ -12,7 +12,7 @@ const { deleteMasterMeasure } = require('./lib/deletemeasure');
 
 const { getBookmark } = require('./lib/getbookmark');
 
-const { importMasterItemFromFile } = require('./lib/importexcel');
+const { importMasterItemFromFile } = require('./lib/import-masteritem-excel');
 
 const { scrambleField } = require('./lib/scramblefield');
 const { getScript } = require('./lib/getscript');

diff --git a/src/lib/importexcel.js → src/lib/import-masteritem-excel.js b/src/lib/importexcel.js → src/lib/import-masteritem-excel.js
@@ -125,6 +125,8 @@ const importMasterItemFromExcel = async (options) => {
         // Loop through rows in Excel file, extracting data for rows flagged as master items
         let importCount = 0;
         if (sheet && sheet.data.length > 0) {
+            let rowCount = 0;
+
             // Loop through all rows
             // eslint-disable-next-line no-restricted-syntax
             for (const row of sheet.data) {
@@ -301,10 +303,15 @@ const importMasterItemFromExcel = async (options) => {
                         }
                     }
                 } else {
-                    logger.warn(
-                        `Found an unknown master item type: "${row[colPosMasterItemType]}". Ignoring this line in the imported file.`
-                    );
+                    // Don't warn if it's the first line/header in the Excel file
+                    // eslint-disable-next-line no-lonely-if
+                    if (rowCount !== 0) {
+                        logger.warn(
+                            `Found an unknown master item type: "${row[colPosMasterItemType]}". Ignoring this line in the imported file.`
+                        );
+                    }
                 }
+                rowCount += 1;
             }
         }