Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panel: question about email sending #137

Closed
Linux123123 opened this issue Jan 4, 2021 · 3 comments · Fixed by #140
Closed

panel: question about email sending #137

Linux123123 opened this issue Jan 4, 2021 · 3 comments · Fixed by #140
Assignees

Comments

@Linux123123
Copy link
Member

Linux123123 commented Jan 4, 2021

Describe the issue
So basically we can skip the question about sending emails, because if we set APP_ENVITONMENT_ONLY=false we can have the user change it from panel.

To Reproduce
Steps to reproduce the behaviour:

  1. Run the script
  2. Choose panel
  3. Get the question

Betterbehaviour
It shouldn't ask for it.

Screenshots
image

OS (please complete the following information):

  • OS: All
  • Installation: panel

Additional context
It is a lot easier to set them from within the panel. Also most users set the APP_ENVITONMENT_ONLY=false anyway, so the script can automatically do it.

@vilhelmprytz
Copy link
Member

vilhelmprytz commented Jan 4, 2021

Can we set APP_ENVIRONMENT_ONLY=false via php artisan? (Also this is not really a bug)

@Linux123123
Copy link
Member Author

No, it doesn't have, but we could use something like sed to change it. (just used a bug template...)

@vilhelmprytz
Copy link
Member

image

It's limited to configuring SMTP from the interface, but I agree. I'll fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants