Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wings: Skip the virtualization warnings #160

Closed
MichelBaie opened this issue Feb 12, 2021 · 7 comments · Fixed by #179
Closed

wings: Skip the virtualization warnings #160

MichelBaie opened this issue Feb 12, 2021 · 7 comments · Fixed by #179
Labels
new feature Introduces a new feature wings wings

Comments

@MichelBaie
Copy link
Contributor

Add an argument to allow installing on LXC because it works :)

@sinjs
Copy link
Contributor

sinjs commented Feb 12, 2021

Docker in LXC is not officially supported by Docker. Many people will have trouble with installing with the script, so I would keep the warning.

@Linux123123
Copy link
Member

The script is doing what the pterodactyl official install guide is doing. In the System Requirements it says that "If your provider makes use of Virtuozzo, OpenVZ (or OVZ), or LXC then you will most likely be unable to run Wings". Based on that we are not allowing to install wings when using Virtuozzo, OpenVZ (or OVZ), or LXC.

@vilhelmprytz
Copy link
Member

The panel may run on LXC and OpenVZ and as far as I know, there is no check that prevents that. Wings, however, require Docker which most likely won't run with LXC or OpenVZ. I am not sure about LXC, but Virtuozzo has "experimental support" that requires the host machine to enable it (see this).

Closing.

@MichelBaie
Copy link
Contributor Author

Idk if i can re-open this issue, but many hosters are using Proxmox to create Containers LXC. And it's only a box to check to make nesting (Docker) working. Pterodactyl is running perfectly with this box checked. A lot of french hosts are especially allowing docker on their lxc hosting offers.

This is why i proposed to add an argument like --ignore-lxc or others, to allow pterodactyl to be installed on these containers.
A lot of customers are asking for help to manually install Pterodactyl, because they can't use this installation script.

@MichelBaie
Copy link
Contributor Author

I didn't have a lot of skills in Bash to modify the script and ignore this warning, so it's why i asked for it.

@vilhelmprytz
Copy link
Member

Ah, I see. I'll reopen the issue but I am yet to decide if this is going to be implemented. I see the use case and I understand it's frustrating that the script doesn't let the user override the check. We'll definitely change something, but maybe not in the form of a command line option! 🙂

In the meantime, you can remove this line to override the check. https://github.com/vilhelmprytz/pterodactyl-installer/blob/600d8dc78adb0b0069618a5b03cd7469e6778c2c/install-wings.sh#L237

@vilhelmprytz vilhelmprytz reopened this Feb 22, 2021
@vilhelmprytz vilhelmprytz added new feature Introduces a new feature wings wings labels Feb 22, 2021
@MichelBaie
Copy link
Contributor Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Introduces a new feature wings wings
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants