Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNAME records not supported #201

Closed
jobhh opened this issue Jul 1, 2021 · 1 comment · Fixed by #202
Closed

CNAME records not supported #201

jobhh opened this issue Jul 1, 2021 · 1 comment · Fixed by #202
Labels
bug Something isn't working
Projects
v1.0.0
Milestone
v1.0.0

Comments

@jobhh
Copy link
Contributor

jobhh commented Jul 1, 2021 •
edited

Is your feature request related to a problem? Please describe.
Using CNAME records results in the script claiming a domain does not point to the proper IP address.

Describe the solution you'd like
Support CNAME records.

Describe alternatives you've considered
None.

Additional context
Ran the script on a clean Debian 10 installation

This is the logging for an example where sub.primarydomain.com points to sub2.diffrentdomain.com, which points to sub3.duckdns.org, which points to 10.0.0.22:

* I agree that this HTTPS request is performed (y/N): y
* Resolving DNS for sub.primarydomain.com
* The DNS record (sub2.diffrentdomain.com.
sub3.duckdns.org.
10.0.0.22) does not match your server IP. Please make sure the FQDN games.wehlan.nl is pointing to the IP of your server, 10.0.0.22
* If you are using Cloudflare, please disable the proxy or opt out from Let's Ecnrypt.
* Proceed anyways (your install will be broken if you do not know what you are doing)? (y/N):

Please note that the IP does actually show up in the DNS record, alongside the CNAME records.
@jobhh jobhh changed the title Support DNAME records Support CNAME records Jul 1, 2021
jobhh added a commit to jobhh/pterodactyl-installer that referenced this issue Jul 1, 2021
@jobhh
Allow CNAME DNS records
841f997 
Disclaimer: I have only tested this in an online bash shell, please check if it properly works.

This should fix the situation where a CNAME record is used to point to a domain that points to the proper IP address.
It does break when someone creates a domain that contains the ip address, but I think that's an even bigger edge case than using CNAME records.

Closes pterodactyl-installer#201
@jobhh jobhh mentioned this issue Jul 1, 2021
Merged
@jobhh jobhh changed the title Support CNAME records CNAME records not supported Jul 1, 2021
@vilhelmprytz vilhelmprytz added the bug Something isn't working label Jul 2, 2021
@vilhelmprytz
Copy link
Member

Thank you for reporting this. This should definitely be fixed and the current behavior is undesirable.

@vilhelmprytz vilhelmprytz added this to the v1.0.0 milestone Jul 2, 2021
@vilhelmprytz vilhelmprytz added this to To do in v1.0.0 via automation Jul 2, 2021
v1.0.0 automation moved this from To do to Done Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
v1.0.0
Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Allow CNAME DNS records jobhh/pterodactyl-installer
2 participants
@jobhh @vilhelmprytz