-
-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panel: Use php8.0 #168
panel: Use php8.0 #168
Conversation
This is not working on Ubuntu 20.04. Are you sure PHP 8 is available natively? I couldn't find it on packages.ubuntu.com.
|
I swear I searched it before and it was in |
I usually think it's best to go with the versions released by the distribution maintainers if it's supported by Pterodactyl. For the older distros, we have to add using the PPA anyways so why not just go with the latest supported. But I think we should stay with 7.4 until Pterodactyl doesn't work with it anymore for focal since that's included in the repository. What do you think? |
I have now verified that these are working.
|
Of course I also see your point and totally agree, but is it really worth to hold of the |
Sure, go with PHP 8. Does the sury repo work with Ubuntu? |
Yes. I have already pushed out the commit. |
Now also tested to work on Ubuntu 20.04. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Use
php8.0
instead ofphp7.4
.PHP 8
is supported since panelv1.3.0
Everything should work as expected as it basically was find 7.4 and replace it with 8.0. (Mostly because
sury
repo includes8.0
)Tested on
Debian 10