Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panel: Use php8.0 #168

Merged
merged 4 commits into from
Mar 16, 2021
Merged

panel: Use php8.0 #168

merged 4 commits into from
Mar 16, 2021

Conversation

Linux123123
Copy link
Member

@Linux123123 Linux123123 commented Mar 6, 2021

Use php8.0 instead of php7.4. PHP 8 is supported since panel v1.3.0

Everything should work as expected as it basically was find 7.4 and replace it with 8.0. (Mostly because sury repo includes 8.0)

Tested on Debian 10

@vilhelmprytz vilhelmprytz self-requested a review March 7, 2021 17:12
@vilhelmprytz vilhelmprytz self-assigned this Mar 7, 2021
@vilhelmprytz vilhelmprytz added the panel panel label Mar 7, 2021
@vilhelmprytz
Copy link
Member

This is not working on Ubuntu 20.04. Are you sure PHP 8 is available natively? I couldn't find it on packages.ubuntu.com.

* Installing dependencies for Ubuntu 20..
Reading package lists... Done
Building dependency tree       
Reading state information... Done
ca-certificates is already the newest version (20210119~20.04.1).
ca-certificates set to manually installed.
curl is already the newest version (7.68.0-1ubuntu2.4).
curl set to manually installed.
gnupg is already the newest version (2.2.19-3ubuntu2.1).
gnupg set to manually installed.
software-properties-common is already the newest version (0.98.9.4).
software-properties-common set to manually installed.
The following NEW packages will be installed:
  apt-transport-https
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 1704 B of archives.
After this operation, 161 kB of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu focal-updates/universe amd64 apt-transport-https all 2.0.4 [1704 B]
Fetched 1704 B in 0s (13.4 kB/s)              
Selecting previously unselected package apt-transport-https.
(Reading database ... 63155 files and directories currently installed.)
Preparing to unpack .../apt-transport-https_2.0.4_all.deb ...
Unpacking apt-transport-https (2.0.4) ...
Setting up apt-transport-https (2.0.4) ...
'universe' distribution component is already enabled for all sources.
Reading package lists... Done
Building dependency tree       
Reading state information... Done
E: Unable to locate package php8.0
E: Couldn't find any package by glob 'php8.0'
E: Unable to locate package php8.0-cli
E: Couldn't find any package by glob 'php8.0-cli'
E: Unable to locate package php8.0-gd
E: Couldn't find any package by glob 'php8.0-gd'
E: Unable to locate package php8.0-mysql
E: Couldn't find any package by glob 'php8.0-mysql'
E: Unable to locate package php8.0-pdo
E: Couldn't find any package by glob 'php8.0-pdo'
E: Unable to locate package php8.0-mbstring
E: Couldn't find any package by glob 'php8.0-mbstring'
E: Unable to locate package php8.0-tokenizer
E: Couldn't find any package by glob 'php8.0-tokenizer'
E: Unable to locate package php8.0-bcmath
E: Couldn't find any package by glob 'php8.0-bcmath'
E: Unable to locate package php8.0-xml
E: Couldn't find any package by glob 'php8.0-xml'
E: Unable to locate package php8.0-fpm
E: Couldn't find any package by glob 'php8.0-fpm'
E: Unable to locate package php8.0-curl
E: Couldn't find any package by glob 'php8.0-curl'
E: Unable to locate package php8.0-zip
E: Couldn't find any package by glob 'php8.0-zip'
vagrant@ubuntu-focal:/vagrant$

@Linux123123
Copy link
Member Author

I swear I searched it before and it was in repos. Now after a bit more looking it's not, but the ondrej/php PPA includes it and we are already using it for Ubuntu 18. So I will just add it in 20 too I guess.

@vilhelmprytz
Copy link
Member

I usually think it's best to go with the versions released by the distribution maintainers if it's supported by Pterodactyl. For the older distros, we have to add using the PPA anyways so why not just go with the latest supported. But I think we should stay with 7.4 until Pterodactyl doesn't work with it anymore for focal since that's included in the repository. What do you think?

@vilhelmprytz
Copy link
Member

I have now verified that these are working.

  • Ubuntu 18.04
  • CentOS 7
  • CentOS 8
  • Debian 9
  • Debian 10

@Linux123123
Copy link
Member Author

Linux123123 commented Mar 10, 2021

I usually think it's best to go with the versions released by the distribution maintainers if it's supported by Pterodactyl. For the older distros, we have to add using the PPA anyways so why not just go with the latest supported. But I think we should stay with 7.4 until Pterodactyl doesn't work with it anymore for focal since that's included in the repository. What do you think?

Of course I also see your point and totally agree, but is it really worth to hold of the php 8? Based on how it is was before Ubuntu 20.04 won't have php8.0 in it's repositories or it's going to be far far later. Yes this is a PPA and isn't as secure / maintained as php 7.4 is in the main repositories. Anyway my main point is that Ubuntu 20.04 might not support it at all. Also as with any new release of PHP it brings better performance, security updates and a lot more things. Also it would be quite strange that all the older distributions like Debian 9 or CentOS 7 gets the update and Ubuntu 20.04 doesn't?

@vilhelmprytz
Copy link
Member

vilhelmprytz commented Mar 10, 2021

Sure, go with PHP 8. Does the sury repo work with Ubuntu?

@Linux123123
Copy link
Member Author

Yes. I have already pushed out the commit.

@vilhelmprytz
Copy link
Member

Now also tested to work on Ubuntu 20.04.

Copy link
Member

@vilhelmprytz vilhelmprytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vilhelmprytz vilhelmprytz merged commit b9f8480 into pterodactyl-installer:master Mar 16, 2021
vilhelmprytz added a commit that referenced this pull request Mar 16, 2021
after #168 merge
@Linux123123 Linux123123 deleted the linux123123-PR branch March 16, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
panel panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants