Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panel: fix ln bug if file exist #182

Merged
merged 1 commit into from
May 21, 2021
Merged

panel: fix ln bug if file exist #182

merged 1 commit into from
May 21, 2021

Conversation

Linux123123
Copy link
Member

@Linux123123 Linux123123 commented May 17, 2021

Fixed a critical bug if configure_nginx is run again and ln fails, because the file exists. I added the -f flag so it forces to remove the file, if it already exists.

fixes #186

@Linux123123 Linux123123 changed the title panel: fix ln bug if file exist panel: fix ln bug if file exist May 17, 2021
Copy link
Member

@vilhelmprytz vilhelmprytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for finding and submitting the PR. But before I merge, can you create a bug report issue and link it to this PR (i.e. add "fixes #xx" to description)?

@vilhelmprytz vilhelmprytz self-assigned this May 21, 2021
@vilhelmprytz vilhelmprytz added bug Something isn't working panel panel labels May 21, 2021
@vilhelmprytz
Copy link
Member

Thanks for opening the issue, merging.

@vilhelmprytz vilhelmprytz merged commit d300608 into pterodactyl-installer:master May 21, 2021
@Linux123123 Linux123123 deleted the linux123123-fix branch May 21, 2021 18:43
vilhelmprytz added a commit that referenced this pull request May 21, 2021
after #182 merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working panel panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panel: ln fails if file already exists
2 participants