Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[panel] Check if FQDN is an IP #300

Merged
merged 2 commits into from
Mar 14, 2022
Merged

[panel] Check if FQDN is an IP #300

merged 2 commits into from
Mar 14, 2022

Conversation

Linux123123
Copy link
Member

Add's a regex check similar to email, to check if provided FQDN is an IP.

@Linux123123
Copy link
Member Author

This is only panel, because it would require quite a bit more work on wings script.

Copy link
Member

@vilhelmprytz vilhelmprytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried this locally and it still allows me to proceed with automatic Let's Encrypt. Without looking too much at the code, have you verified that this is working?

@Linux123123
Copy link
Member Author

I just retested and that regex doesn't work that well. So I just added a much simpler ip checking with ip.

Copy link
Member

@vilhelmprytz vilhelmprytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works a lot better now. Thanks, LGTM!

@vilhelmprytz vilhelmprytz merged commit 4ff66c4 into pterodactyl-installer:master Mar 14, 2022
vilhelmprytz added a commit that referenced this pull request Mar 14, 2022
after #300 merge
@Linux123123 Linux123123 deleted the ipcheck branch August 4, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants