-
-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lib script, rocky and almalinux support #315
Add lib script, rocky and almalinux support #315
Conversation
@vilhelmprytz the Ignore the failed builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial read-through: this looks very promising, nice work @Linux123123! It looks like you've done some work on Wings as well already, would it be suitable if I merged this into a new branch and continued your work on it? If so, would you be able to resolve the current conflicts with master
?
I think I have the merge conflicts solved locally already, but yes we can continue on a new branch. |
For now, I will leave the let's encrypt logic separate in panel and wings, as one is using nginx and the other one the standalone option in |
Now to check for the millions of bugs introduced in this PR… I will mark it as ready for review as in vagrant on Ubuntu jammy I can run both panel and wings scripts without any major issues. But still need to test other distros. |
Thanks for this, I'll merge into a new branch ( |
WIP, not sure how #280 PR will adapt / be merged.
Currently
panel.sh
has been tested in Ubuntu 20.04 and is at least partially working.I moved a lot of redundant logic from scripts to lib, so I may have forgotten about something. My goal is to unify as much as possible all the scripts to have the same functions available to minimize overlap.
panel
wings