Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mysql command to mariadb #545

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Jcodeerd
Copy link

@Jcodeerd Jcodeerd commented Sep 14, 2023

As seen on this screenshot, taken today, the mysql command will be deprecated when using MariaDB image

I do have a few questions though,

  • Do I also have to change the references from "MySQL" to "MariaDB" in the guides?
  • Should I also change the command for the legacy installation guide? panel/0.7/getting_started.md

@Boy132
Copy link
Contributor

Boy132 commented Sep 15, 2023

As we support both mysql and mariadb I would say it's better to add both commands. Similar to how nginx & apache commands are separated. Something like:

# If using MySQL
mysql -u root -p

# If using MariaDB (version x+ [whatever version they will rename it])
mariadb -u root -p
  • Do I also have to change the references from "MySQL" to "MariaDB" in the guides?
  • Should I also change the command for the legacy installation guide? panel/0.7/getting_started.md

No and no

@Jcodeerd
Copy link
Author

AFAIK there's no specific date given yet, I've put it as v11.0.0+ for now

@QuintenQVD0
Copy link
Contributor

Wy not put mariadb first? As that is what the default docs install.

@Jcodeerd
Copy link
Author

Good point, I don't really think it matters (users should know whether they are using mariadb or mysqld), but I'll change it

@matthewpi matthewpi mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants