Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return to latest powerstate #136

Closed
BentHaase opened this issue Oct 10, 2016 · 16 comments
Closed

Return to latest powerstate #136

BentHaase opened this issue Oct 10, 2016 · 16 comments
Labels
feature request A request for a new feature.

Comments

@BentHaase
Copy link

BentHaase commented Oct 10, 2016

As discussed on Discord, a feature which will return the servers on one node to their power state before a potential crash of the Daemon or an unplanned reboot / crash of the host system will reduce the stress on an admin to remember the correct state of each server before.

This could be further improved by allowing the following three settings upon a daemon coming online:

  • Power on all servers on this node
  • Return all servers to their previous power state
  • Power on all servers with the selected option to power on with daemon (has to be added to the servers settings)
  • Keep all servers powered off

To avoid load spikes, a defineable delay between starting the servers will be beneficial. (30 seconds should be a good value to start with).

Let me know if this fit's here or should be more a daemon feature.

@Wqrld

This comment has been minimized.

@schrej
Copy link
Member

schrej commented Jun 20, 2018

Why rethink? It's still open isn't it?

@Wqrld
Copy link

Wqrld commented Jun 20, 2018

This was opened a long time ago and i thought i'd bump it as it kinda disappeared.

@eggroll-bot
Copy link

When is this going to be done?

@DaneEveritt
Copy link
Member

DaneEveritt commented Nov 13, 2018

Eventually. Its not a trivial task with the current state of the daemon.

@Doonut
Copy link

Doonut commented May 20, 2019

why has this been open for nearly 3 years? This is a very useful and basic feature of even docker itself.

@schrej
Copy link
Member

schrej commented May 20, 2019

It's still open because no one implemented it so far, feel free to do so.
We might be able to leverage dockers restart policy, but that would probably break the current crash detection that only tries to restart a container a few times instead of forever.

@DaneEveritt
Copy link
Member

Age of an issue does not determine the priority of implementation. In addition, I've already given this a swing once and it was significantly more difficult to properly implement than imagined, which is why it is still here.

@YeapGuy

This comment has been minimized.

@DaneEveritt
Copy link
Member

closed for now in pterodactyl/wings@85762ba

@lancepioch lancepioch unpinned this issue Feb 21, 2020
@alekitopi
Copy link

The return to the previous state only works in some containers (ex: minecraft), in the custom containers or Voice Server containers do not work. I don't know if it's my fault but it doesn't seem to be.

@Fieel
Copy link

Fieel commented Jul 29, 2020

So what are we supposed to do in case of a an unexpected shutdown? Re-start manually all servers? Genuinely confused

@schrej
Copy link
Member

schrej commented Jul 29, 2020

The issue is closed. It's implemented in the 1.0 betas.

So what are we supposed to do in case of a an unexpected shutdown? Re-start manually all servers? Genuinely confused

On stable, yes.

@CitizenPrayer
Copy link

It's been eight years since this was first proposed, and two years since the last comment on the idea. Was this just dropped and forgotten, or is someone actually working on this?

@schrej
Copy link
Member

schrej commented Oct 14, 2022

This issue is closed. That means that this is implemented. 1.0 was released a long time ago.

@arkanataya

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A request for a new feature.
Projects
None yet
Development

No branches or pull requests