Add new audit log types #3854
Closed
Add new audit log types #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hwalker928
reviewed
Feb 6, 2022
itsgatto
reviewed
Feb 11, 2022
app/Http/Controllers/Api/Client/Servers/ScheduleTaskController.php
Outdated
Show resolved
Hide resolved
|
Maybe adding also user actions like login/logout or last login. |
|
Thank you for taking the time to do this, but I'm still on the fence about my audit logging implementation, and it needs more testing from me before I'd feel good about moving forwards with it. As a result, and also per the contribution changes I am going to close out this PR. https://github.com/pterodactyl/panel/blob/develop/CONTRIBUTING.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added new logging types to cover almost all server actions.
I changed the way the old logging worked by migrating the backup uuid to backup name so the user UI can be constructed with more ease, without having to execute hundreds or possibly thousands of databases query's. With this comes a nice, completely functional, database migration file.