build glfw as a dynamic library

pthom · Nov 15, 2022 · 4ebefe9 · 4ebefe9
1 parent 5bb4e04
commit 4ebefe9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/cmake/add_hello_imgui.cmake b/cmake/add_hello_imgui.cmake
@@ -15,8 +15,16 @@ function (add_hello_imgui)
         enable_language(OBJC) # See https://gitlab.kitware.com/cmake/cmake/-/issues/24104
     endif()
 
-    # 2.1 Build glfw (also used by hello_imgui)
+    # 2.1 Build glfw as a *shared* library (this is required if we want to be able to use python bindings
+    # for glfw, using https://github.com/FlorianRhiem/pyGLFW)
+    # Note: the rpath is set by a call to
+    #     lg_target_set_rpath(${python_native_module_name} ".")
+    # (inside add_imgui_bundle_bindings)
+    set(BUILD_SHARED_LIBS ON)
     add_subdirectory(external/glfw)
+    install(TARGETS glfw DESTINATION .)
+    set(BUILD_SHARED_LIBS OFF)
+
     if (UNIX AND NOT APPLE)
         # Those are only needed for wheels build using cibuildwheel (cp36-manylinux_x86_64 wheel)
         # See https://bytemeta.vip/repo/glfw/glfw/issues/2139

diff --git a/cmake/add_imgui_bundle_bindings.cmake b/cmake/add_imgui_bundle_bindings.cmake
@@ -40,5 +40,6 @@ function(add_imgui_bundle_bindings)
         target_link_libraries(${python_native_module_name} PUBLIC cvnp)
     endif()
 
+    lg_target_set_rpath(${python_native_module_name} ".")
     target_link_libraries(${python_native_module_name} PUBLIC ${bound_library})
 endfunction()