Hovering a Pin when adding a Link is causing the canvas to clip

[krejov100]

I have found that the node editor canvas is clipping when attempting to create a link.
I believe it is related to this issue in the underlying imgui-node-editor, which has a workaround.
thedmd/imgui-node-editor#237

Screen.Recording.2023-07-02.at.11.49.10.AM.mov

[pthom]

Hi,

It is strange that the issue was closed in the imgui-node-editor repository. Having an issue or a related PR would be the best way to get this to be solved in the main repository.

Did you try the workaround on your side with your project, and does it fix the issue?

[krejov100]

I have not reproduced the workaround, I've been using the precompiled wheel from pip.
I did also find this possibly related issue that remains open on the imgui-node-editor repository.

thedmd/imgui-node-editor#205

[pthom]

Could you post a minimal reproducible example?

[krejov100]

To reproduce, it requires the graph to be in a docking window, and the clipping is screen position depended.

from imgui_bundle import imgui, imgui_node_editor as ed, immapp
from imgui_bundle.immapp import static, run_anon_block as anon
from imgui_bundle import hello_imgui


@immapp.static(id=0)
def next_id():
    next_id.id += 1
    return next_id.id

@immapp.static(id=0)
def next_link_id():
    next_link_id.id += 1
    return next_link_id.id

def gui():
    next_id.id = 0

    ed.begin("My Editor", imgui.ImVec2(0.0, 0.0))

    ed.begin_node(ed.NodeId(next_id()))
    imgui.text("Node 1")
    ed.begin_pin(ed.PinId(next_id()), ed.PinKind.output)
    imgui.text("Out ->")
    ed.end_pin()
    ed.end_node()

    ed.begin_node(ed.NodeId(next_id()))
    imgui.text("Node 2")
    ed.begin_pin(ed.PinId(next_id()), ed.PinKind.input)
    imgui.text("-> In")
    ed.end_pin()
    ed.end_node()

    if ed.begin_create():
        input_pin_id = ed.PinId()
        output_pin_id = ed.PinId()
        if ed.query_new_link(input_pin_id, output_pin_id):
            if ed.accept_new_item():
                ed.link(ed.LinkId(next_link_id()), input_pin_id, output_pin_id)
    ed.end_create()

    ed.end()


runner_params = immapp.RunnerParams()
runner_params.imgui_window_params.menu_app_title = "Pipeline"
runner_params.imgui_window_params.enable_viewports = True
win = hello_imgui.DockableWindow()
win.gui_function = gui
win.label = "graph"
runner_params.docking_params.dockable_windows = [win]

add_on_params = immapp.AddOnsParams()
add_on_params.with_node_editor = True

immapp.run(runner_params, add_on_params)

[pthom]

Yes, the workaround seems to solve the issue.
I will consider adding this to my node fork, will keep you posted

[krejov100]

Thank you for reproducing!

[pthom]

Hi, I just pushed a commit that correct this:

• correction in the node editor fork
• update submodule in this repository

As of now, I did not release a new version of the pip package (this might take a few weeks, as I want to group updates).
If you want the modification on your side, you will need to build the pip package from source.

git clone https://github.com/pthom/imgui_bundle.git
cd imgui_bundle
git submodule update --init --recursive  # Since there are lots of submodules, this might take a few minutes
pip install -v . # The build process might take up to 15 minutes
pip install opencv-contrib-python

[pthom]

I'll need to find an appropriate way to transmit the fix to @thedmd, together with an easily reproducible example.

I'll work on this a little later.

[thedmd]

@pthom Issue is now resolved in node editor. Thanks for your help!

[pthom]

This issue is now fixed, and also fixed in @thedmd repo. Thanks a lot!