Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYNAREC_RV64] Fixed A0 MOV AL,Ob #866

Merged
merged 2 commits into from
Jun 26, 2023
Merged

[DYNAREC_RV64] Fixed A0 MOV AL,Ob #866

merged 2 commits into from
Jun 26, 2023

Conversation

ksco
Copy link
Collaborator

@ksco ksco commented Jun 26, 2023

No description provided.

@ksco
Copy link
Collaborator Author

ksco commented Jun 26, 2023

I fixed rv64_move32 in 9861c4f above! On a very rare condition, the original implementation could be wrong: like MOV64x(x1, 0x7fffffff0000).

Original:

        lui     a0, 524288 // 0x80000
        addi    a0, a0, -1
        slli    a0, a0, 16
        ret

Fixed:

        lui     a0, 524288 // 0x80000
        addiw   a0, a0, -1
        slli    a0, a0, 16
        ret

@ptitSeb ptitSeb merged commit 7e514ce into ptitSeb:main Jun 26, 2023
20 checks passed
@ksco ksco deleted the fix branch June 26, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants