New instructions and other fixes #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
M-HT
commented
Mar 21, 2019
M-HT
commented
- Add fnstsw, lahf, rep movsw instructions
- Fix div function in libc wrapper
- Use dummy error handler in function my_snd_lib_error_set_handler in libasound wrapper
- Add interrupt flag to default emu flags
…apper; Use dummy error handler in function my_snd_lib_error_set_handler in libasound wrapper; Add interrupt flag to default emu flags
ptitSeb
reviewed
Mar 21, 2019
src/wrappedlibc_private.h
Outdated
| @@ -195,7 +195,7 @@ GO(__dgettext, pFpp) | |||
| GO(difftime, dFuu) | |||
| GO(dirfd, iFp) | |||
| GO(dirname, pFp) | |||
| GO(div, UFii) | |||
| GOM(div, pFpii) | |||
There was a problem hiding this comment.
As div return a struct, I think it will need the GOS macro to put a RET 4 instead of RET (like with ldiv function)
There was a problem hiding this comment.
I studied more about how it actually works and you're right. I fixed it in new commit. Although it's strange that it worked with RET instead of RET 4.
There was a problem hiding this comment.
Yeah, when I count the number of error I fixed, I would say it's surprisingly resilient to mistakes!
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.