Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified code #309

Merged
merged 3 commits into from Jan 11, 2021
Merged

Simplified code #309

merged 3 commits into from Jan 11, 2021

Conversation

QueenPew
Copy link
Contributor

Removed some redundant if elses, fixed some typos in the documentation and reworded some sentences.

@ptitSeb
Copy link
Owner

ptitSeb commented Jan 11, 2021

You realize that the else vs early return chnage nothing in term of optimisation?

@ptitSeb ptitSeb merged commit 4b020ab into ptitSeb:master Jan 11, 2021
@QueenPew
Copy link
Contributor Author

Yes, I know that.

But still, I think that removing the redundant if elses make the code more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@QueenPew @ptitSeb