Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add A64 profile #488

Merged
merged 2 commits into from
Oct 30, 2021
Merged

Add A64 profile #488

merged 2 commits into from
Oct 30, 2021

Conversation

Danct12
Copy link
Contributor

@Danct12 Danct12 commented Oct 30, 2021

Tested on Pine64 PinePhone, was able to start Uplink Hacker Elite.

@ptitSeb ptitSeb merged commit 2d18421 into ptitSeb:master Oct 30, 2021

`mkdir build; cd build; cmake .. -DA64=1 -DCMAKE_BUILD_TYPE=RelWithDebInfo; make -j$(nproc)`

As most Allwinner A64 device run AARCH64 OS, you'll need an `armhf` multiarch environment, and an armhf gcc: On debian, install it with `sudo apt install gcc-arm-linux-gnueabihf`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this already has been merged, but I don't like that you're calling it "armhf". "armhf" is ambiguous and can either mean ARMv7 or ARMv6. I'm not even sure which you mean here. What are your thoughts?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARMHF is ARMv7 HardFloat
On Debian and Ubuntu, you use sudo dpkg --add-architecture armhf to add the armhf architecture (using multiarch).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but on e.g. Alpine ARMHF is ARMv6 Hard Float, and ARMv7 is just called ARMv7. But, sure, more people will probably think of Debian's name for it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see armhf is just how it's called in other places too, so not really an issue specific to this PR then.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is multiarch available on Alpine?

Copy link
Contributor

@Newbytee Newbytee Nov 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not (but from what I understand it's in the works?), but they support multiple architectures and you can create an armhf chroot for example. That said, I don't think Box86 builds on musl anyway, so maybe it doesn't matter.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, musl is a problem indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants