Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYNAREC] Added check of dyn's size #589

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Conversation

wannacu
Copy link
Contributor

@wannacu wannacu commented Mar 17, 2022

No description provided.

@ptitSeb
Copy link
Owner

ptitSeb commented Mar 17, 2022

Why are you adding this check? did you have a case when the dynablock would grow in an uncontrolable way?

@wannacu
Copy link
Contributor Author

wannacu commented Mar 17, 2022

Why are you adding this check? did you have a case when the dynablock would grow in an uncontrolable way?

Yes, dyn inst size more than 10000, then updateNeed encounter deep recursion

@ptitSeb
Copy link
Owner

ptitSeb commented Mar 17, 2022

But is that block valid?

@wannacu
Copy link
Contributor Author

wannacu commented Mar 17, 2022

But is that block valid?

From inst log, it looks valid, and after cancelbock, it works well.

@ptitSeb
Copy link
Owner

ptitSeb commented Mar 17, 2022

If it's leggit x86 code, it's a shame to waste such big block. Putting a cut in dynarec_arm_pass.c doesn't work? (the updateNeed function still bomb?)

@wannacu
Copy link
Contributor Author

wannacu commented Mar 17, 2022

If it's leggit x86 code, it's a shame to waste such big block. Putting a cut in dynarec_arm_pass.c doesn't work? (the updateNeed function still bomb?)

It work well after putting a cut.

@ptitSeb ptitSeb merged commit ccfc8a8 into ptitSeb:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants