Fix some wrapping error #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptitSeb
reviewed
Mar 6, 2023
src/wrapped/wrappedlibjpeg.c
Outdated
| @@ -309,6 +352,13 @@ EXPORT void* my_jpeg_std_error(x86emu_t* emu, void* errmgr) | |||
|
|
|||
| wrapErrorMgr(my_lib->w.bridge, ret); | |||
|
|
|||
| my->jpeg_std_error(&native_err_mgr); | |||
| ret->error_exit = (void*)AddBridge(my_lib->w.bridge, vFp, native_error_exit, 0, NULL); | |||
There was a problem hiding this comment.
it's probably better to use AddCheckBridge here, to avoid adding multiple time the same value?
ptitSeb
reviewed
Mar 6, 2023
src/include/bridge.h
Outdated
| @@ -12,6 +13,7 @@ void FreeBridge(bridge_t** bridge); | |||
|
|
|||
| uintptr_t AddBridge(bridge_t* bridge, wrapper_t w, void* fnc, int N, const char* name); | |||
| uintptr_t CheckBridged(bridge_t* bridge, void* fnc); | |||
| bool IsBridge(void* func); | |||
There was a problem hiding this comment.
I know it's nitspicking, but can we avoid the use of bool? a simple int will do just fine.
ptitSeb
requested changes
Mar 6, 2023
|
Ok, I will improve it |
ptitSeb
approved these changes
Mar 6, 2023
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.