DYNAREC Regression causing segfault.

[BlackHazel]

Commit bac874c caused regressions on both momodora_reverie_under_the_moonlight_1_062_24682.sh and shovel_knight_treasure_trove_4_0a_34523.sh for whatever reason.

The only change in log between fdf0aaa (working) & bac874c (error) on Momodora

create stream 300016
create stream 300017
create stream 300018
create stream 300019
create stream 300020
create stream 300021
create stream 300022
create stream 300023
create stream 300024
create stream 300025
MAP LOADING DS MAP CREATING
config.ini readed
stringMapPreload() called.
Set Fullscreen 1
sync = 1
**** GLX Extensions ***
GLX_ARB_create_context GLX_ARB_create_context_no_error GLX_ARB_create_context_profile GLX_ARB_fbconfig_float GLX_ARB_framebuffer_sRGB GLX_ARB_get_proc_address GLX_ARB_multisample GLX_EXT_buffer_age GLX_EXT_create_context_es2_profile GLX_EXT_create_context_es_profile GLX_EXT_fbconfig_packed_float GLX_EXT_framebuffer_sRGB GLX_EXT_import_context GLX_EXT_texture_from_pixmap GLX_EXT_visual_info GLX_EXT_visual_rating GLX_INTEL_swap_event GLX_MESA_copy_sub_buffer GLX_MESA_query_renderer GLX_MESA_swap_control GLX_OML_swap_method GLX_OML_sync_control GLX_SGIS_multisample GLX_SGIX_fbconfig GLX_SGIX_pbuffer GLX_SGIX_visual_select_group GLX_SGI_make_current_read GLX_SGI_swap_control GLX_SGI_video_sync 
Checking for GLX_EXT_swap_control
Checking for GLX_SGI_swap_control
Vsync: GLX_SGI
enabling vsync.
vsync: 1
buffer compatible
initialized analytics
ERROR: enter a number as value
gamepad get device count: 4
gamepad connected on slot 0
Input Mode set to: Controller Profile A
Changing Fog to: 99
Changing Fog to: 0
Changing music.
StartGame() - DONE
Total memory used = 41268935(0x08ae7079) bytes
**********************************.
Entering main loop.
**********************************.
gamepad get device count: 4
gamepad connected on slot 0
Input Mode set to: Controller Profile A

But newer version segfault directly.

create stream 300017
create stream 3000
Erreur de segmentation

Shovel Knight working:

Warning, call to pthread_attr_setschedparam(...) ignored
Warning, call to pthread_attr_setschedparam(...) ignored
Warning, call to pthread_attr_setschedparam(...) ignored
Warning, call to pthread_attr_setschedparam(...) ignored
Note: File effects/flareoExplosionSpecter.anb was already loaded
Shutdown
GameShutdown
Threads Shutdown
Force Exit

And crashing:

Warning, call to pthread_attr_setschedparam(...) ignored
Warning, call to pthread_attr_setschedparam(...) ignored
Warning, call to pthread_attr_setschedparam(...) ignored
Warning, call to pthread_attr_setschedparam(...) ignored
ycAssert! ../engine/src/ycTexture.cpp: 239
if(!(ret == 0)): 
WARN: 

Assertion failure at Break (../engine/src/ycAssert.cpp:101), triggered 1 time:
  '0'

Abort/Break/Retry/Ignore/AlwaysIgnore? [abriA] :

No other relevant change into the default log I think, but I still uploaded them if needed.

momodora_1_working_fdf0aaa.zip
momodora_1_working_fdf0aaa_debug.zip
momodora_2_bissect_bac874c.zip
momodora_2_bissect_bac874c_debug.zip
momodora_3_upstream_8affc55.zip
momodora_3_upstream_8affc55_debug.zip

shovelknight_1_working_fdf0aaa.zip
shovelknight_1_working_fdf0aaa_debug.zip
shovelknight_2_bissect_bac874c.zip
shovelknight_2_bissect_bac874c_debug.zip
shovelknight_3_upstream_8affc55.zip
shovelknight_3_upstream_8affc55_debug.zip

[ptitSeb]

Oh, so I broken Shovel Knight and Momodora, again :(

Ok, with the offending commit, it will help. I'll look at that tonight.

[ptitSeb]

It's automatically closed by github, but I assume it's indeed fixed (it worked for me). Is it ok for you too?

[BlackHazel]

Compiled the latest build this morning, Momodora & Regression Knight (cough) Shovel Knight are booting without issue, tested on 4.19.75 @ Mesa 19.2.0-rc1 and 5.4.3 @ Mesa 20.0.0-devel (git-ed0fa78b46) (rpi4b+), only tested 5mins on each game and no problem to report, however 5.4.3 is still not ready for prime time yet so better using 4.19.x at this time.

I've also quickly tested Unreal Tournament and it's still working without any problem so we can assume the problem is solved and don't cause any know regression for the moment.

Thanks for always fixing the reported bug this fast ptitSeb!

[ptitSeb]

\o/
thanks for testing!