Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with : state change from verisur app and changing status from home app #11

Open
enzofrnt opened this issue Dec 15, 2021 · 16 comments
Assignees
Labels
enhancement New feature or request

Comments

@enzofrnt
Copy link

That impossible to get a state change without it goes unresponsive. Same for changing state from homeapp. Update ? That unusable

@lenny005
Copy link

Hello, did you find a solution ? Still having this issue

@enzofrnt
Copy link
Author

no and you ?

@lenny005
Copy link

No, pinging the dev on twitter

@enzofrnt
Copy link
Author

already try he do nothing, sadly

@ptz0n
Copy link
Owner

ptz0n commented Jun 20, 2022

Please contribute with code, I'll review PR's.

@lenny005
Copy link

I would really like to but I am no dev. But i can contribute with coffee or else ? (Paypal ?)

@lenny005
Copy link

If you don’t have verisure anymore maybe i can give you access to mine temporary to try stuff ? @ptz0n

@ptz0n
Copy link
Owner

ptz0n commented Jun 22, 2022

Problem summary; Verisure responds too slow for the Home app. We cannot receive a confirmation on requests until the Home app hits its timeout. This timeout is out of our control.

We could do an optimistic update approach. This means that we cache and return the current and target arm state before it has been confirmed by Verisure. Home app will (hopefully) be happy to get the faked confirmation when you do a state change, even before the actual state has been changed in the Verisure system.

Later, if we for some reason could not set the target state (Verisure down, slower than usual etc.) this will have to update the state again which will be communicated back to the Home app.

This is more complex but hopefully feel a bit more reliable from a user perspective.

@ptz0n ptz0n added the enhancement New feature or request label Jun 22, 2022
@ptz0n
Copy link
Owner

ptz0n commented Jun 22, 2022

Related issue: #1

@lenny005
Copy link

@ptz0n Here is one fork of your work that seam to be working, maybe it can help you ?

master...mmoriani:master

@lenny005
Copy link

@PIORIGIN I see that user @mmoriani forked @ptz0n as stated above (master...mmoriani:master) and he pushed it on homebridge repo if you want to try: Homebridge Securitas Direct
@ottimis/homebridge-securitas-direct v1.0.1 (2021-09-19)

He seems to have repair the plugin. Can't try it right now

@ptz0n
Copy link
Owner

ptz0n commented Jul 22, 2022

Great that the fork is working. I'm happy to review, cleanup and publish these changes if @mmoriani would like to submit a PR.

@mmoriani
Copy link

Hello!
My intention was to test the changes and do a PR, but I was unable to test it thoroughly due to lack of time.
I think there is something more that could be improved/fixed.
I can try to spend some time on it in the next few weeks or do a PR directly. @ptz0n what do you prefer?

@ptz0n
Copy link
Owner

ptz0n commented Jul 22, 2022

Whip up what you have and submit a PR. I'm happy to help out with reviewing and updating tests etc.

@mmoriani
Copy link

@ptz0n I remembered that I also modified the node-securitas-direct package to use the APIs that are now used in the new desktop webapp.
However, I realized that they now require MFA... So something seems to be broken at login. The rest of the code still seems to work, but need a solution for the login.
I was looking for a solution this morning, but i need more time to understand.

I've seen the same problem here.

What do you think?

@enzofrnt
Copy link
Author

enzofrnt commented Aug 6, 2022

do we have any news ? need some beta tester ?

Repository owner deleted a comment from Soumya6Tiwari Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants