CHANGE #791 set enumerable for non-privates

pubkey · Sep 13, 2018 · 0090123 · 0090123
1 parent bbf3153
commit 0090123
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/examples/angular2/app/src/components/heroes-list/heroes-list.component.ts b/examples/angular2/app/src/components/heroes-list/heroes-list.component.ts
@@ -41,6 +41,9 @@ export class HeroesListComponent implements OnInit, OnDestroy {
             .sort({ name: 1 })
             .$;
         this.sub = heroes$.subscribe(heroes => {
+            console.log('heroes:');
+            console.dir(heroes);
+
             this.heroes = heroes;
             this.zone.run(() => { });
         });

diff --git a/src/rx-collection.js b/src/rx-collection.js
@@ -123,18 +123,32 @@ export class RxCollection {
                 const props = Object.getOwnPropertyNames(obj);
                 props.forEach(key => {
                     const desc = Object.getOwnPropertyDescriptor(obj, key);
+
+
+                    /**
+                     * When enumerable is true, it will show on console.dir(instance)
+                     * To not polute the output, only getters and methods are enumerable
+                     */
+                    let enumerable = true;
+                    if (
+                        key.startsWith('_') ||
+                        key.endsWith('_') ||
+                        key.startsWith('$') ||
+                        key.endsWith('$')
+                    ) enumerable = false;
+
                     if (typeof desc.value === 'function') {
                         // when getting a function, we automatically do a .bind(this)
                         Object.defineProperty(proto, key, {
                             get() {
                                 return desc.value.bind(this);
                             },
-                            enumerable: false,
+                            enumerable,
                             configurable: false
                         });
 
                     } else {
-                        desc.enumerable = false;
+                        desc.enumerable = enumerable;
                         desc.configurable = false;
                         if (desc.writable)
                             desc.writable = false;