use deleted flag for pushing in graphql replication #3446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should start with a test to pin down the 'correct' behavior in the CI. |
|
@chrisdrackett what is the status of this? |
|
yeah, sorry, haven't had much time for this yet. I'll try and get a test case in this week |
|
I think this is actually fine now that I look at it more. I'm pretty sure we were just using it wrong. I was looking for our flag in our query builder when I should have been looking for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Describe the problem you have without this PR
Fixes #3436
I don't feel like this is a full fix yet as I'm not sure how if a doc is deleted in pouch that gets set via the deleted flag. I think this has something to do with checking for if this is a delete operation, but I'm not sure why that was changed via 480c56b#diff-9d7498b685187264496834aaae5e2d04b1273c86b921c6b1bc1a2bf5c797f6d8 and I don't want to rebreak things without understanding the fix.
Todos