Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split out watchForChanges to support external replications #197

Merged
merged 1 commit into from Jun 5, 2017
Merged

Split out watchForChanges to support external replications #197

merged 1 commit into from Jun 5, 2017

Conversation

natew
Copy link
Contributor

@natew natew commented Jun 5, 2017

This allows me to implement query based sync until its more officially supported.

@pubkey pubkey merged commit d7a6733 into pubkey:master Jun 5, 2017
pubkey added a commit that referenced this pull request Jun 5, 2017
@pubkey
ADD #197
da7bfa6
pubkey added a commit that referenced this pull request Jun 5, 2017
@pubkey
REVERT one line of #197 because it breaks the tests
ac6860a
@pubkey
Copy link
Owner

pubkey commented Jun 5, 2017

I merged this but had to revert one thing. You removed the following line
.filter(doc => !this._changeEventBuffer.buffer.map(cE => cE.data.v._rev).includes(doc._rev))
but removing this breaks the tests. Did this happen on purpose, and if yes, what was not working with this filter?

@natew
Copy link
Contributor Author

natew commented Jun 5, 2017

Oh strange, did not notice I had removed that! No reason other than my error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@natew @pubkey