Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance local document types #2850

Merged
merged 2 commits into from
Feb 6, 2021
Merged

Enhance local document types #2850

merged 2 commits into from
Feb 6, 2021

Conversation

openscript
Copy link
Contributor

This PR contains:

  • IMPROVED typings

Describe the problem you have without this PR

The typing of insertLocal in rx-database.d.ts and rx-collection.d.ts was the following:

    insertLocal<LocalDocType = any>(id: string, data: any): Promise<...>;

I haven't discovered any reason, why data should not be typed with the LocalDocType as upsertLocal() does it too.

There was also some code redundancy between rx-database.d.ts and rx-collection.d.ts, which was resolved as well.

A typing test was added accordingly.

@pubkey pubkey merged commit d578ac7 into pubkey:master Feb 6, 2021
pubkey added a commit that referenced this pull request Feb 6, 2021
@pubkey
Copy link
Owner

pubkey commented Feb 6, 2021

@openscript thank you. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants