Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show atomicUpsert bug with graphql #3856

Closed
wants to merge 1 commit into from

Conversation

AntonOfTheWoods
Copy link
Contributor

This PR contains:

  • IMPROVED TESTS

Describe the problem you have without this PR

Commit 9f93496 introduced a bug whereby a test that all elements of the _meta dict are already present at the time of the test. Investigation into the state in the actual objects appears to suggest that is not the case at the time of the test but is the case later in the database.

Sorry this is not in the bug-report.test.ts. Everything required was available in the previous test so in order to keep things manageable I just copy-pasted.

@pubkey pubkey closed this in 1a9de37 Jun 18, 2022
@pubkey
Copy link
Owner

pubkey commented Jun 18, 2022

I fixed this. RxDocument._saveData() does not merge the _meta fields instead of replacing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants