Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled is-my-json-valid unit test #3935

Closed
wants to merge 1 commit into from
Closed

Conversation

linco95
Copy link

@linco95 linco95 commented Aug 16, 2022

This PR contains:

  • A BUGFIX

Describe the problem you have without this PR

Reenabled unit test for is-my-json-valid as per premium task
Depends on PR #193 of is-my-json-valid

Todos

  • Tests
  • Documentation
  • Typings
  • Changelog

@pubkey
Copy link
Owner

pubkey commented Sep 6, 2022

The CI is green but mafintosh/is-my-json-valid#193 is not merged.
I do not understand why this happens. Can you rebase this PR to the latest master?

@linco95
Copy link
Author

linco95 commented Sep 14, 2022

@pubkey I've rebased it to latest master now.
I agree, it's weird that the CI is green without the PR being merged 🤔

@pubkey
Copy link
Owner

pubkey commented Sep 14, 2022

Still green. This is so strange. is-my-json-valid didn't even have a release.

@pubkey
Copy link
Owner

pubkey commented Sep 14, 2022

Ah I found it, I forgot to throw the error.
Fixed in 2fe1cc3
Can you rebase again please?
Sorry for hassle.

@linco95
Copy link
Author

linco95 commented Sep 15, 2022

@pubkey No worries. Rebase is done 👍🏻

@stale
Copy link

stale bot commented Mar 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon. If you still have a problem, make a PR with a test case or to prove that you have tried to fix the problem.

@stale stale bot added the wontfix label Mar 26, 2023
@pubkey pubkey removed the wontfix label Mar 26, 2023
@pubkey
Copy link
Owner

pubkey commented Mar 26, 2023

Sorry the stale bot was not meant for PRs.

@pubkey
Copy link
Owner

pubkey commented Sep 12, 2023

Hi @linco95
I am so sorry but I think the is-my-json-valid repo is dead an this will never be merged.
I am closing this PR to remove it from my todo list.
If it will ever be merged, just ping me an I will reopen.

@pubkey pubkey closed this Sep 12, 2023
pubkey added a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants