Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy triple slash directives #4023

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Remove legacy triple slash directives #4023

merged 1 commit into from
Oct 10, 2022

Conversation

jeromepochat
Copy link
Contributor

I'm facing build issue when using RxDB from Angular project due to triple-slash directive usage in pouchdb-helper.d.ts.

Minimal project to reproduce issue

  • packages.json
{
  "dependencies": {
    "rxdb": "^13.4.5"
  }
}
  • main.ts
import { addPouchPlugin, getRxStoragePouch } from 'rxdb/plugins/pouchdb'

console.log("Hello world")
  • tsconfig
{
  "compilerOptions": {
    "types": []
  }
}

Build command line

npm i && tsc

Build error

...
node_modules/@types/node/ts4.8/buffer.d.ts:97:14 - error TS2661: Cannot export 'Buffer'. Only local declarations can be exported from a module.

97     export { Buffer };
                ~~~~~~


Found 1 error in node_modules/@types/node/ts4.8/buffer.d.ts:97

@pubkey
Copy link
Owner

pubkey commented Oct 10, 2022

Thank you merged.

pubkey added a commit that referenced this pull request Oct 10, 2022
@pubkey pubkey merged commit 52518bf into pubkey:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants