A bug report about $lt selector on primaryKey on RxStorageDexie
#4751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youxkei
commented
May 28, 2023
Comment on lines
+126
to
132
| const myDocuments = await collectionInOtherTab.mycollection | ||
| .find({ | ||
| selector: { | ||
| passportId: { $lt: '002' }, | ||
| }, | ||
| }) | ||
| .exec(); |
There was a problem hiding this comment.
myDocuments should have only alice's passport because we have a selector passportId: { $lt: '002' }.
youxkei
commented
May 28, 2023
Comment on lines
+138
to
+148
| assert.deepStrictEqual( | ||
| myDocuments.map((doc) => doc.toJSON()), | ||
| [ | ||
| { | ||
| passportId: '001', | ||
| firstName: 'Alice', | ||
| lastName: 'Kelso', | ||
| age: 56, | ||
| }, | ||
| ] | ||
| ); |
There was a problem hiding this comment.
npm run test:browser:dexie says
bug-report.test.js
✗ should fail because it reproduces the bug
Expected values to be strictly deep-equal:
+ actual - expected
[ { passportId: '001',
firstName: 'Alice',
lastName: 'Kelso',
+ age: 56 },
+ { passportId: '002',
+ firstName: 'Bob',
+ lastName: 'Kelso',
+ age: 45 } ]
- age: 56 } ]
|
@youxkei please rebase with master. This is likely already fixed. |
youxkei
force-pushed
the
bug-storage-dexie-lt-on-pk
branch
from
636e372
to
71b51f1
Compare
|
@pubkey Thank you for your work! I rebased it. |
|
Working on a fix in #4891 |
|
Fixed here #4891 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Describe the problem you have without this PR
There seems a bug for
$ltselector on primaryKey on RxStorageDexie.