Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation name graphql #5418

Merged
merged 4 commits into from Dec 25, 2023
Merged

Operation name graphql #5418

merged 4 commits into from Dec 25, 2023

Conversation

jwallet
Copy link
Contributor

@jwallet jwallet commented Dec 21, 2023

This PR contains:

  • A NEW FEATURE
  • breaking the helper function

Describe the problem you have without this PR

GraphQL operationName is required with some tools to valid the gQL request

We used patch-package to change this in rxdb but we will like to be able to upgrade without it.

@pubkey
Copy link
Owner

pubkey commented Dec 22, 2023

Hi @jwallet
Do you think this is a breaking change?

@jwallet
Copy link
Contributor Author

jwallet commented Dec 22, 2023 via email

@jwallet
Copy link
Contributor Author

jwallet commented Dec 22, 2023

I changed the helper functions queryBuilderFromRxSchema to prevent a breaking change with the pullStream.

@jwallet
Copy link
Contributor Author

jwallet commented Dec 22, 2023

Also, if someone uses a query like the one below, he can just ignore the "operationName" param, but the operationName must match the name after query/mutation keyword, and if after the merge no one provide an operationName, it will just stay like before the merge since the param is optional.

query($checkpoint: CheckpointInput, $limit: Int!)
                    {
                        collectionFeedForRxDBReplication(checkpoint: $checkpoint, limit: $limit) {
                            collection {
                                documents {
                                    id
                                    name
                                    age
                                    updatedAt
                                    deleted
                                }
                                checkpoint {
                                    id
                                    updatedAt
                                }
                            }
                        }
                    }

@pubkey pubkey merged commit d74f129 into pubkey:master Dec 25, 2023
21 checks passed
@pubkey
Copy link
Owner

pubkey commented Dec 25, 2023

Thank you, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants