replication-webrtc: allow passing config to simple-peer #5838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users may need to pass an RTCPeerConnection configuration object to simple-peer through the plugin. This simply adds an optional parameter to getConnectionHandlerSimplePeer. This is mostly likely to be used to pass a custom ICE server list for STUN and TURN servers.
|
Hi @cleech |
pubkey
added a commit
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may need to pass an RTCPeerConnection configuration object to simple-peer through the plugin. This simply adds an optional parameter to getConnectionHandlerSimplePeer.
This is mostly likely to be used to pass a custom ICE server list for STUN and TURN servers.
Describe the problem you have without this PR
Issue #5835