Replication alive$ #809
Merged
Replication alive$ #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
|
This is done. As a curiosity, why do we have dist files in the git repo? Wouldn't it make sense to include it in the |
|
They are commited so people can try the latest version without having to do a build. |
motin
reviewed
Sep 18, 2018
docs-src/replication.md
Outdated
| Emits `true` or `false` depending if the replication is alive - data is transmitting properly between databases. A `false` value implies the connection has died -if you're replicating to a remote database, for example. It will only emit `false` if there are pending changes that couldn't be replicated -it won't emit immediately after the connection dies. | ||
|
|
||
| ```js | ||
| replicationState.active$.subscribe(active => console.dir(active)); |
pubkey
added a commit
that referenced
this pull request
Sep 18, 2018
motin
reviewed
Sep 18, 2018
| Emits `true` or `false` depending if the replication is alive - data is transmitting properly between databases. A `false` value implies the connection has died -if you're replicating to a remote database, for example. It will only emit `false` if there are pending changes that couldn't be replicated -it won't emit immediately after the connection dies. | ||
|
|
||
| ```js | ||
| replicationState.alive$.subscribe(alive => console.dir(active)); |
There was a problem hiding this comment.
Typo: console.dir(active) -> console.dir(alive)
motin
reviewed
Sep 18, 2018
| @@ -59,6 +59,13 @@ Emits `true` or `false` depending if the replication is transmitting data. A `fa | |||
| replicationState.active$.subscribe(active => console.dir(active)); | |||
| ``` | |||
|
|
|||
| ### alive$ | |||
| Emits `true` or `false` depending if the replication is alive - data is transmitting properly between databases. A `false` value implies the connection has died -if you're replicating to a remote database, for example. It will only emit `false` if there are pending changes that couldn't be replicated -it won't emit immediately after the connection dies. | |||
There was a problem hiding this comment.
Nit: missing spaces after the dashes in "-if" and "-it"
There was a problem hiding this comment.
I'm a native Spanish speaker; in Spanish dashes go without inner spaces. Is that not the case for English?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds alive$
Relates to #763