Prepare 1.6 release #317
Merged
Prepare 1.6 release #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not create_activity on an update action unless model is changed
Rails 5.1 compatibility for update action (for PR public-activity#290)
Adding license info to the Gemspec.
`base_class` in ActiveRecord returns `PublicActivity::ORM::ActiveRecord::Activity` incorrectly. Since `PublicActivity::ORM::ActiveRecord::Activity` is really an abstract class for all intents and purposes, it should be declared so that `base_class` returns `PublicActivity::Activity` instead. My use case was using the `unread` gem to track who had read an activity. It uses `base_class` to record the polymorphic type of the `readable` which is the Activity in this case. All the tests passed with this addition but I’ve added another to ensure that `base_class` returns the correct value.
`base_class` is an `ActiveRecord` method and doesn’t apply to other ORM’s.
…s-true Set self.abstract_class = true
Use rails_helper instead of spec_helper for disabling public_activity
Fix the readme, missing ')'
mongo-mapper gem relies on mongo 1.x but versions >= 1.10.0 started using upsert in a way that is incompatible with mongo 3.x
|
If you get Travis notifications and I just spammed the crap out of your mailbox then I apologize! Fixing those builds felt like this: I've made sure Travis is green now. @pokonski, anything else that is required before you can release 1.6 ? |
|
@pokonski Any chance you'll look at it or you're not interested in development anymore and it makes more sense to fork? :) (sorry for applying pressure but I need this release) |
|
Hey @d4rky-pl, for some reason I missed your PR! Let's get this released, then 😁 I could definitely use some active maintainers, and I'm open to get some help :) |
This was referenced Jul 20, 2018
This was referenced Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, @pokonski!
I know you're not using this library anymore and you are relying on community testing so I've upgraded this gem on a pretty big existing codebase that previously used 1.4 and ran it's test suite. Everything seems to be working fine (and it seems I'm not the only one that did it)!
I've merged the changes from 1-5-stable branch to this one and applied patch from #315 to make it work in our project. What else do you need to release 1.6?