Handle ActiveRecord::NoDatabaseError exception #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes rake db:create task for rails 5.2 Related Information rails/rails#32870 (comment)
chopraanmol1
force-pushed
the
handle_no_database_error_exception
branch
from
417cd24
to
e0bfe5f
Compare
|
The current behavior, when the table doesn't exist, is to skip serialization. To keep things consistent I've skipped serialization for the scenario when a database doesn't exist. I've also added a warning message when the above scenarios happen. But I think it can be argued that default behavior for the above two scenarios should be to serialize without checking for column type instead of skipping serialization(as we cannot check column type). I think the default behavior should be discussed and if a change is required, I'll modify this PR or create another PR whichever is more appropriate. |
|
This fixes my error upon database create. |
|
Fantastic! Thanks for the fix @chopraanmol1! |
|
Fix released in 1.6.2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #322
Related Information
rails/rails#32870 (comment)