Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Virdipay Game Player Check #3023

Closed
wants to merge 1 commit into from
Closed

Add Virdipay Game Player Check #3023

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 23, 2022

add api

  • My submission is formatted according to the guidelines in the contributing guide
  • My addition is ordered alphabetically
  • My submission has a useful description
  • The description does not have more than 100 characters
  • The description does not end with punctuation
  • Each table column is padded with one space on either side
  • I have searched the repository for any relevant issues or pull requests
  • Any category I am creating has the minimum requirement of 3 items
  • All changes have been squashed into a single commit

matheusfelipeog
matheusfelipeog suggested changes Jan 28, 2022
View reviewed changes
Copy link
Collaborator

@matheusfelipeog matheusfelipeog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @sialexsofficial ;)

Can you revolve the review, please?

And can you also let me know if this API is completely free or is it necessary to pay to use it?

README.md
@@ -866,7 +866,8 @@ API | Description | Auth | HTTPS | CORS |
| [When is next MCU film](https://github.com/DiljotSG/MCU-Countdown/blob/develop/docs/API.md) | Upcomimg MCU film information | No | Yes | Unknown |
| [xkcd](https://xkcd.com/json.html) | Retrieve xkcd comics as JSON | No | Yes | No |
| [Yu-Gi-Oh!](https://db.ygoprodeck.com/api-guide/) | Yu-Gi-Oh! TCG Information | No | Yes | Unknown |

| [Api game player name check](bit.ly/apiplayercek) | Get information player name by id game | `apiKey` | Yes | No |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this:

  • Use API name as title
  • Use the documentation link, not a bit.ly
  • Fix the alphabetical order
  • And follow the correct formatting of the .md file
Suggested change
| [Api game player name check](bit.ly/apiplayercek) | Get information player name by id game | `apiKey` | Yes | No |
| [Virdipay Game Player Check](https://documenter.getpostman.com/view/13751573/UVXjKbts) | Get information player name by id game | `apiKey` | Yes | No |

@matheusfelipeog matheusfelipeog added alphabetical ordering is required The entry is not in the alphabetical order. awaiting PR evolution labels Jan 28, 2022
@matheusfelipeog matheusfelipeog changed the title Update README.md Add Virdipay Game Player Check Jan 28, 2022
@matheusfelipeog
Copy link
Collaborator

I tried to get in touch to get more information about this API, however I didn't get a response:

image

Therefore, I will not accept this PR.

@matheusfelipeog matheusfelipeog removed awaiting PR evolution alphabetical ordering is required The entry is not in the alphabetical order. labels Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matheusfelipeog