add INSA by NASA #22
Merged
add INSA by NASA #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
reviewed
Feb 28, 2018
p/insa/example.js
Outdated
| // longitude: 11.641705 | ||
| // }, | ||
| // { distance: 200 } | ||
| // ) |
There was a problem hiding this comment.
Please indent this block like in the other example files.
derhuerst
reviewed
Feb 28, 2018
test/insa.js
Outdated
| const isRoughlyEqual = require("is-roughly-equal"); | ||
| const validateFptf = require("validate-fptf"); | ||
|
|
||
| const co = require("./co"); |
There was a problem hiding this comment.
Use single quotes wherever possible. See https://standardjs.com/rules.html
derhuerst
reviewed
Feb 28, 2018
test/insa.js
Outdated
| const when = createWhen("Europe/Berlin", "de-DE"); | ||
|
|
||
| const assertValidStationProducts = (t, p) => { | ||
| return null; // todo |
derhuerst
reviewed
Feb 28, 2018
test/insa.js
Outdated
| const client = createClient(insaProfile); | ||
|
|
||
| test( | ||
| "Magdeburg Hbf to Magdeburg-Buckau", |
There was a problem hiding this comment.
Please indent this tests like e.g. test/oebb.js.
|
Thanks a lot! ❤️ Things still to do:
|
|
@jfilter friendly ping (: |
- apparently INSA doesn't return prices
|
There are only the |
Closed
|
Thanks @derhuerst for all the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.