Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canada: add more Transitland Feeds #75

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

Pi-Cla
Copy link
Contributor

@Pi-Cla Pi-Cla commented Mar 2, 2024

Add every Transitland feed I could find which is not in B.C, Ontario, or Quebec (as those have a lot of feeds...)

@Pi-Cla
Copy link
Contributor Author

Pi-Cla commented Mar 2, 2024

Just read a PR comment about wanting space free names so gonna rebase that real quick...

@nekohayo
Copy link

nekohayo commented Mar 2, 2024

While we're here, this might be relevant to your interests: transitland/transitland-atlas#1024

@nekohayo
Copy link

nekohayo commented Mar 2, 2024

Also, why not add the B.C., Ontario and Quebec feeds from the Canadian feeds? Those would be very useful IMHO, they are the most populous metropolitan areas.

In addition / as an alternative to the transitfeeds website listing, there is also an official (govt provided) overall view of the Québec province's various cities ("ville") offering feeds: https://www.rtcquebec.ca/en/open-data

@Pi-Cla
Copy link
Contributor Author

Pi-Cla commented Mar 2, 2024

Also, why not add the B.C., Ontario and Quebec feeds from the Canadian feeds? Those would be very useful IMHO, they are the most populous metropolitan areas.

In addition / as an alternative to the transitfeeds website listing, there is also an official (govt provided) overall view of the Québec province's various cities ("ville") offering feeds: https://www.rtcquebec.ca/en/open-data

Mostly cause it would be a lot of new feeds and this region json is already pretty big so I am not sure if I want maintainer responsibility for all of those.

One thought I have is perhaps splitting this into something like: B.C, Ontario, Quebec, Rest-of-Canada
so that each json file is not too big. I could then add you as a maintainer for B.C (and Ontario/Quebec if you want)

@Pi-Cla
Copy link
Contributor Author

Pi-Cla commented Mar 2, 2024

If the above sounds good to @nekohayo, @mlundblad and the Transitous maintainers then I will reword this PR to split the Canada region...

@jbruechert
Copy link
Collaborator

You can split up the regions if you want. :)

Currently they are split up by country, but we previously already had a separate region for Berlin for example

@Pi-Cla
Copy link
Contributor Author

Pi-Cla commented Mar 2, 2024

@jbruechert this PR is ready to be CI'd and then merged.

I will only split this region up if someone shows interest in being listed as a maintainer for additional feeds in B.C, Quebec, or Ontario. So far no one has so this can be merged as is

@Pi-Cla Pi-Cla force-pushed the patch-1 branch 4 times, most recently from 2e768c0 to 60bacb0 Compare March 2, 2024 20:38
@jbruechert
Copy link
Collaborator

There is a problem / limit in MOTIS that appears to be hit when adding more feeds, so I'll need to delay merging this unfortunately.
Hopefully that will be fixed soon.

Sorry to break the enthusiasm :(

Add every Transitland feed I could find which is not in B.C, Ontario, or Quebec (as those have a lot of feeds...)
Right now feed is broken on transitland
transitland/transitland-atlas#1025
@jbruechert jbruechert merged commit 03b13dc into public-transport:main Mar 3, 2024
2 checks passed
@Pi-Cla Pi-Cla deleted the patch-1 branch March 5, 2024 04:01
@derhuerst derhuerst added the data sources adding, removing, modifying or discussing problems with specific data sources label Mar 19, 2024
@derhuerst derhuerst changed the title Add More Canadian Transitland Feeds Canada: add more Transitland Feeds Mar 19, 2024
@mlundblad mlundblad mentioned this pull request Mar 31, 2024
84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data sources adding, removing, modifying or discussing problems with specific data sources
Development

Successfully merging this pull request may close these issues.

None yet

4 participants