[v2] Allow propagation of keyup events on input elements (#5689)

public-ui · Dec 5, 2023 · c1efc5c · c1efc5c
2 parents 1c2bcd2 + a4e141e
commit c1efc5c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/packages/components/src/components/@deprecated/input/controller.ts b/packages/components/src/components/@deprecated/input/controller.ts
@@ -147,7 +147,6 @@ export class InputController extends ControlledInputController implements Watche
 		const value = (event.target as HTMLInputElement).value;
 
 		// Event handling
-		stopPropagation(event);
 		tryToDispatchKoliBriEvent('change', this.host, value);
 
 		// Static form handling

diff --git a/packages/components/src/components/tooltip/component.tsx b/packages/components/src/components/tooltip/component.tsx
@@ -39,7 +39,7 @@ export class KolTooltip implements API {
 		if (this.previousSibling && this.tooltipElement /* SSR instanceof HTMLElement */) {
 			showOverlay(this.tooltipElement);
 			this.tooltipElement.style.setProperty('display', 'block');
-			getDocument().body.addEventListener('keyup', this.hideTooltipByEscape);
+			getDocument().addEventListener('keyup', this.hideTooltipByEscape);
 
 			const target = this.previousSibling;
 			const tooltipEl = this.tooltipElement;
@@ -59,11 +59,11 @@ export class KolTooltip implements API {
 				this.cleanupAutoPositioning = undefined;
 			}
 		}
+		getDocument().removeEventListener('keyup', this.hideTooltipByEscape);
 	};
 
 	private hideTooltipByEscape = (event: KeyboardEvent): void => {
 		if (event.key === 'Escape') {
-			getDocument().body.removeEventListener('keyup', this.hideTooltipByEscape);
 			this.hideTooltip();
 		}
 	};