Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS layers POC #5424

Merged
merged 14 commits into from
Oct 23, 2023
Merged

Add CSS layers POC #5424

merged 14 commits into from
Oct 23, 2023

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Oct 13, 2023

No description provided.

Copy link
Contributor

@deleonio deleonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kurze Rückfrage: Warum haben wir das nicht bei allen anderen CSS Datein in components machen/angeben müssen?

sdvg and others added 3 commits October 16, 2023 15:14
* 'develop' of github.com:public-ui/kolibri: (37 commits)
  v1.7.2-rc.0
  Add border-radius to outlines for buttons and accordion headers
  chore: tiny optimization
  fix: lint
  Update snapshots
  Table: Fix heading color
  Alert: Change font-style and update color for info messages
  Fix color for warning alerts
  Fix border color for invalid inputs of all types
  Fix checkbox border color on hover
  Fix link color in active/focus/hover state
  Fix primary button color
  Fix select colors, add custom chevron to allow for color adjustments
  Fix button hover style
  fix: format
  fix: unused
  style(KolInputCheckbox): change switch icon
  Fix radio button hover style
  Add template tags
  chore: update snapshots
  ...
* develop: (43 commits)
  fix: format
  Update snapsnots
  Add zoll-v3
  Improve samples
  chore: hide labels
  chore: remove v1.5
  chore: update snapshots
  docs: fix readme
  v2.0.0-rc.1
  fix: missing dependency over npmjs registry
  fix: kolibri-theme template for create app
  chore: remove core
  chore: update deps and lock
  fix: register-service-worker
  v2.0.0-rc.0
  v1.7.2
  chore: restore default readme
  Fix border-radius for buttons in zollv2-theme
  chore: separate default theme
  Implement SampleDescription component
  ...
padding: 0.125rem;
& span {
background-color: var(--color-blue-75);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warum kannst Du den Style hier entfernen?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Korrigiere mich gerne, aber soweit ich nachvollziehen konnte wurde hier eigentlich nur die Hintergrundfarbe angewandt. Ich sehe mit meinen Änderungen keinen Unterschied zu vorher, nur eine leichte Verschiebung des Spinners wurde entfernt.

@deleonio deleonio linked an issue Oct 23, 2023 that may be closed by this pull request
* 'develop' of github.com:public-ui/kolibri:
  v2.0.0-rc.2
  chore: update snaps
  chore: update readme's
  Update test
  Refactor details icon to one icon, that's rotated via CSS
  fix: speech texts
  fix: code
  fix: type
  chore: restore compact button
  chore: make _label required
@sdvg sdvg marked this pull request as ready for review October 23, 2023 18:50
@deleonio deleonio merged commit 3aa261b into develop Oct 23, 2023
2 checks passed
@deleonio deleonio deleted the layers branch October 23, 2023 20:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS Layers nutzen
2 participants