Add access key to button #5482
Merged
Add access key to button #5482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
…ure-shotcuts-buchstabe-hinter-label-anzeigen * 'develop' of github.com:public-ui/kolibri: restore: toast readme for documentation v2.0.0-rc.4 Update snapshots Remove KolToast from designer entirely Rename component Fix typo Replace remaining KOL-TOAST usages Update desy themes Add readme changes Fix bzst toast theme Remove more unused code Remove unused exports Add missing theme changes Toast Service: Convert Toast component to internal functional component and allow render function instead of description string
deleonio
reviewed
Oct 26, 2023
| label: string; | ||
| accessKey: string; | ||
| }; | ||
| export const InternalUnderlinedAccessKey = ({ label, accessKey }: Props) => { |
There was a problem hiding this comment.
Was passiert, wenn der Access-Key nicht im Label-Text enthalten ist?
deleonio
approved these changes
Oct 26, 2023
| @@ -75,8 +93,14 @@ export class KolSpanWc implements API { | |||
| _hideLabel: false, | |||
| _icons: {}, | |||
| _label: '', // ⚠ required | |||
| _accessKey: '', | |||
There was a problem hiding this comment.
Sollten wir undefined lassen?!
| @@ -163,11 +169,17 @@ export class KolTooltip implements API { | |||
| @Prop() public _label!: LabelPropType; | |||
|
|
|||
| @State() public state: States = { | |||
| _accessKey: '', | |||
There was a problem hiding this comment.
Sollten wir undefined lassen?!
deleonio
deleted the
5392-feature-shotcuts-buchstabe-hinter-label-anzeigen
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.