Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move toast service documentation from deprecated toast component to toast-container #5485

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Move toast service documentation from deprecated toast component to toast-container #5485

merged 4 commits into from
Oct 27, 2023

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Oct 26, 2023

No description provided.

deleonio
deleonio requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@deleonio deleonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitte auf Toaster umbenennen.

packages/components/src/components/toast-container/readme.md Outdated Show resolved Hide resolved
@sdvg sdvg marked this pull request as draft October 27, 2023 07:21
sdvg and others added 2 commits October 27, 2023 09:52
@sdvg
Describe toast render function
ced4902
@sdvg
Merge branch 'develop' into move-toast-docs
de80cdb 
Signed-off-by: Stefan Dietz <sdvg@users.noreply.github.com>
@sdvg sdvg marked this pull request as ready for review October 27, 2023 09:14
@sdvg sdvg linked an issue Oct 27, 2023 that may be closed by this pull request
Toast-Komponente wiederherstellen #5480
Closed
4 tasks
deleonio
deleonio approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@deleonio deleonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vielen Dank @sdvg.

@deleonio deleonio merged commit a7c23b6 into develop Oct 27, 2023
2 checks passed
@deleonio deleonio deleted the move-toast-docs branch October 27, 2023 13:19
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deleonio deleonio deleonio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toast-Komponente wiederherstellen
2 participants
@sdvg @deleonio