Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Define Popover as internal component, remove public API #5545

Merged
merged 7 commits into from
Nov 9, 2023

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Nov 9, 2023

No description provided.

@sdvg sdvg linked an issue Nov 9, 2023 that may be closed by this pull request
@sdvg sdvg changed the title Rename kol-popover to kol-popover-wc and remove public API + react sa… Define Popover as internal component, remove public API Nov 9, 2023
…-popover-wc

* origin:
  chore: update snaps
  fix font-family handling
…ver-rename-to-kol-popover-wc

* 'develop' of github.com:public-ui/kolibri:
  update snapshots
  Bring back purple
  Fix badge examples to ensure minimum color contrast
@deleonio
Copy link
Contributor

deleonio commented Nov 9, 2023

Hi Stefan,

kannst Du bitte bei den Sachen, die v1 und v2 spezifisch sind - bitte von diesem Branch ausgehen: release/v1to2-branch

Die Änderungen ließen sich so direkt in beide Release mergen.

@deleonio
Copy link
Contributor

deleonio commented Nov 9, 2023

Das hätte ich auch gerne für v1

@sdvg sdvg changed the title Define Popover as internal component, remove public API [v2] Define Popover as internal component, remove public API Nov 9, 2023
@deleonio deleonio marked this pull request as ready for review November 9, 2023 18:32
deleonio
deleonio previously approved these changes Nov 9, 2023
@deleonio deleonio merged commit 83ed809 into develop Nov 9, 2023
2 checks passed
@deleonio deleonio deleted the 5543-popover-rename-to-kol-popover-wc branch November 9, 2023 21:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover: Rename to kol-popover-wc
2 participants