Introduce aria-current service #5599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
…-current-handling-via-observer-entkoppeln * 'develop' of github.com:public-ui/kolibri: Fix test scenarios Bring back strong tag to un-break visual tests Remove HTML from sample Table: Always render cells as text to avoid XSS
deleonio
reviewed
Nov 17, 2023
| /** | ||
| * Listen on an aria-current event with this value. If the value matches the current value and the href is the same as the current url, the aria-current attribute will be set to current value. | ||
| */ | ||
| @Prop() public _listenAriaCurrent?: AriaCurrentPropType; |
There was a problem hiding this comment.
@sdvg Hi Stefan, ich finde diesen Prop Name intiutiver.,
There was a problem hiding this comment.
@deleonio Hallo Martin, könntest du das bitte noch etwas näher beschreiben? Diese Property haben (brauchen) wir ja in der Form nicht mehr?
There was a problem hiding this comment.
Für mich ist hier das Lauschen auf den Event/Änderung klarer. Alles gut.
deleonio
approved these changes
Nov 17, 2023
deleonio
deleted the
4314-aria-current-handling-via-observer-entkoppeln
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.