a11y: always preset font and background color #5703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleonio
commented
Dec 6, 2023
| * to black, the contrast ratio is ensured and explicit adjustment is forced. | ||
| */ | ||
| background-color: white; | ||
| color: black; |
There was a problem hiding this comment.
Ich glaube die Snapshot-Tests laufen durch, weil (fast?) alle Beispiele einen weißen Hintergrund haben.
Für Anwendungen mit einem anderen (z.B. hellgrauen) Hintergrund fürchte ich, dass man bei sehr vielen Komponenten die background-color zurück auf transparent setzen müsste, auch wenn diese ihre Farben eigentlich korrekt spezifiziert haben.
Vorschlag: Statt die background-color global auf :host zu setzen, könnten wir sie in den Component-Styles, dort wo es Sinn macht, individuell auf das "visuelle root element" setzen. Bei Button wäre das z.B. kol-span-wc.button-inner.
Zur Veranschaulichung, ein paar Beispiele bei einer App mit dunklem Hintergrund:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.