Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image path in React sample app #5725

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Fix image path in React sample app #5725

merged 2 commits into from
Dec 8, 2023

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Dec 8, 2023

No description provided.

deleonio
deleonio approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@deleonio deleonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sdvg
Copy link
Member Author

sdvg commented Dec 8, 2023

Zur Erklärung: Die Grafik liegt hier: https://public-ui.github.io/v2/sample-react/abgrenzung.jpg
Dadurch, dass die React-App einen Hash-based-Router verwendet und keine "Unterpfade" hat können wir also einfach eine relative URL verwenden ohne die Base-URL zu kennen.

@deleonio deleonio merged commit 1574b0d into develop Dec 8, 2023
3 checks passed
@deleonio deleonio deleted the react-fix-image branch December 8, 2023 08:20
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deleonio deleonio deleonio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sdvg @deleonio