Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update method creation syntax to ES6 DragAction.js #1040

Closed
6 tasks
first-timers bot opened this issue Oct 2, 2022 · 14 comments Β· Fixed by #1113
Closed
6 tasks

Update method creation syntax to ES6 DragAction.js #1040

first-timers bot opened this issue Oct 2, 2022 · 14 comments Β· Fixed by #1113

Comments

@first-timers
Copy link

first-timers bot commented Oct 2, 2022

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

    Once claimed we add you as contributor to this repository.

  • πŸ‘Œ Accept our invitation to this repository. Once accepted, assign yourself to this issue

  • πŸ“ Update the file \src/edit/actions/DragAction.js in the Leaflet.DistortableImage repository (press the little pen Icon) and edit the line as shown below.

@@ -1,5 +1,5 @@
 L.DragAction = L.EditAction.extend({
-  initialize: function(map, overlay, options) {
+  initialize(map, overlay, options) {
     options = options || {};
     options.toolbarIcon = {
       svg: true,
@@ -12,7 +12,7 @@ L.DragAction = L.EditAction.extend({
     L.EditAction.prototype.initialize.call(this, map, overlay, options);
   },
 
-  addHooks: function() {
+  addHooks() {
     var edit = this._overlay.editing;
     edit._dragMode();
   },
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

  • 🏁 Done Ask in comments for a review :)

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@TildaDares
Copy link
Member

Reserved for @Codebat-man for 24 hours

@fonkwe
Copy link
Contributor

fonkwe commented Oct 8, 2022

Hello, please I'd like to be assigned to this issue.

@TildaDares
Copy link
Member

Hi @fonkwe, please go ahead. Thank you!

@NPDebs
Copy link
Contributor

NPDebs commented Oct 9, 2022

Hi @TildaDares. πŸ‘‹πŸΌ
If there's an opening, I'd love to take up this issue please!

@TildaDares
Copy link
Member

Hi @NPDebs, please leave a comment in publiclab/plots2#11105 and we’ll look for an issue for you to work on. Thank you!

@Divine-peace
Copy link

hi @TildaDares.

@Divine-peace
Copy link

Pls, I,m new to open source and i need a project to work on

@Ceejaycodez
Copy link

Hi @TildaDares. I am new to this community and would really love to contribute. Thanks

@xiaodaiweiwei
Copy link
Contributor

Hi @TildaDares. I am a first-timer to this community and would really love to contribute! Thank you!

@TildaDares
Copy link
Member

Hi @Ceejaycodez, please leave a comment in publiclab/plots2#11105 and we’ll look for an issue for you to work on. Thank you!

@TildaDares
Copy link
Member

Hi @xiaodaiweiwei, you have been an assigned a first-timers-only issue already. You can choose to create issues for others or look for other issues without the first-timers-only label to work on. Thank you!

@xiaodaiweiwei
Copy link
Contributor

Ok I got it! Thank you. I have already made a pull request #1103 But I don't know whether there are some errors and have some problems to merge. How could I check for that?

@Chinazaekpere-Ike
Copy link

I'd like to claim this issue πŸ™‹ @TildaDares

@TildaDares
Copy link
Member

Hi everyone, a PR has already been opened for this. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants