Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket connection to 'ws://localhost:8081/ws' failed #1323

Open
jpoep opened this issue Jan 3, 2023 · 13 comments
Open

WebSocket connection to 'ws://localhost:8081/ws' failed #1323

jpoep opened this issue Jan 3, 2023 · 13 comments
Labels

Comments

@jpoep
Copy link

jpoep commented Jan 3, 2023

Describe the bug:
Whenever a page that has this package included is opened, the browser repeatedly attempts to connect to the WebPack dev server at localhost:8081. As I'm not using WebPack, this request constantly fails and it also happens in production. When you open your browser's dev tools, you can observe this behavior in the console. This also happens on the demo site.

grafik

It looks like the package is distributed with a development build, but I haven't looked too far into it. I'm not that familiar with WebPack.

Reproduce the behavior:

Browser, version, and operating system:

  • Happens in all browsers (tested with Chrome, Firefox, and Safari)
  • Versions 108.0.5359.98, 108.0.1, and 16.1 (18614.2.9.1.12) respectively
  • Platform: macOS Ventura

Any help is much appreciated, thanks a lot in advance! :)

@jpoep jpoep added the bug label Jan 3, 2023
@welcome
Copy link

welcome bot commented Jan 3, 2023

Thanks for opening your first issue here! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
You can make a gif too!
Do join our Gitter channel for some brainstorming discussions.

@JoshyB
Copy link

JoshyB commented Jan 13, 2023

I'm having this same issue, and I'm wondering if a solution has been found?

@SashaLifashkin
Copy link

Yeah! I'm having this same issue too.

@rodrigore
Copy link

Same issue

@AntoineB05
Copy link

same issue too

@luke-z
Copy link

luke-z commented Mar 17, 2023

It seems like the problem has been fixed with the release 0.21.10 which somehow isn't available on npm.

The website you linked (https://publiclab.github.io/Leaflet.DistortableImage/examples/index.html) doesn't show the error anymore.

@jpoep
Copy link
Author

jpoep commented Mar 21, 2023

Interesting, thanks for the update! Any idea who is responsible for publishing 0.21.10 on npm? I bet it's where 99% of people pull this library from and it's already been 3 months since the release.

@makrishna
Copy link

It seems like the problem has been fixed with the release 0.21.10 which somehow isn't available on npm.

The website you linked (https://publiclab.github.io/Leaflet.DistortableImage/examples/index.html) doesn't show the error anymore.

Looks like it is not working with websocket builds, can someone have a work around for it.

@tap2k
Copy link

tap2k commented May 9, 2023

Im still having the same issue with 0.21.10 working with NextJS v13.

@tap2k
Copy link

tap2k commented May 29, 2023

Did anyone figure out a solution to fix this?

@Parrryy
Copy link

Parrryy commented Jul 26, 2023

Yeah still having this issue.

@Mustafa-Hersi
Copy link

have anyone found a solution to this?

@yuri-karelics
Copy link

yuri-karelics commented Aug 8, 2023

looks like the only way to fix that is to clone repository locally and make the production build with "npm run build" (I had to disable tests also in gruntfile, they didn't start). When files can be copied into your project from 'dist' folder instead of using NPM package. But keep in mind the latest version of the code in the repository has at least two bugs:

  1. this fix should be reverted, it is wrong 21ad3c7
  2. tooltip support implemented wrong, so if you don't need tooltip it will anyway be shown (empty one). Can be fixed with additional condition that 'this.tooltipText' is not empty before attaching the tooltip

If you don't want to do it yourself, just take from 'dist' folder in this fork https://github.com/Karelics/Leaflet.DistortableImage

P.S. maintainers (@jywarren ?) some unexplainable hell is happening with the repository, development build released into NPM, unstable updates merged into main branch, so new release can't be done without adjestments, ... In general your library looks so cool, but what happened in the last year, could you stabilize the situation, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests