Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most of the actions not working with crs: L.CRS.Simple #805

Closed
jbogdani opened this issue Dec 5, 2020 · 6 comments
Closed

Most of the actions not working with crs: L.CRS.Simple #805

jbogdani opened this issue Dec 5, 2020 · 6 comments
Labels

Comments

@jbogdani
Copy link

jbogdani commented Dec 5, 2020

Hello,
and thank you for this great plugin.

I'm having troubles getting it to work when the map is initialized with crs: L.CRS.Simple.
Drag, Scale, Rotate and Free transform actions are not working, while Distort, Lock, Opacity, Save and Delete do.

The code to reproduce this issue is very simple:

const map = L.map('map', {
    crs: L.CRS.Simple
}).setView([0, 0], 10);

const img = L.distortableImageOverlay('some-image.jpg').addTo(map);

I have tried with the latest versions of Google Chrome, Mozilla Firefox and Safari, with the same results.

@jbogdani jbogdani added the bug label Dec 5, 2020
@welcome
Copy link

welcome bot commented Dec 5, 2020

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

@themacboy
Copy link
Contributor

Oh! Just noticed this issue. This is the same problem a have using CRS too.

Please check my comments in issue #1007. I hope that helps you.

@themacboy
Copy link
Contributor

Current I solved the problem using Math.abs(),but thata not the correct solution, and I'm not sure how to do a better patch

@steveruiz
Copy link

I'm seeing the same problem. Can we disable the check entirely if the map CRS is L.CRS.Simple?

@themacboy
Copy link
Contributor

themacboy commented Sep 13, 2022

I'm seeing the same problem. Can we disable the check entirely if the map CRS is L.CRS.Simple?

I supose that yes, but for me is more easy use Math.abs() and wait for @jywarren patch it

@jywarren
Copy link
Member

jywarren commented Sep 29, 2022

Hello, I'm addressing this here - going to merge this issue into it:

#1007 (comment)

Please follow there and if you can let me know whether the fix works once it's merged, that would be super helpful. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants