Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an image sharpening module #1848

Closed
waridrox opened this issue Mar 14, 2021 · 0 comments · Fixed by #1849
Closed

Adding an image sharpening module #1848

waridrox opened this issue Mar 14, 2021 · 0 comments · Fixed by #1849

Comments

@waridrox
Copy link
Member

waridrox commented Mar 14, 2021

Currently in the image sequencer, it seems there is no image sharpening module which can sharpen the image based on the intensity. This might be very useful for use cases where the image is a bit blurred and needs some sharpening.

The proposed idea for the module, I believe dates back to issue #1612

So, I managed to implement the functionality by applying a 3x3 convolution filter on a given image and transforming it according to this resource

The image does get sharpened but as the intensity is increased, the image gets overexposed.
Screenshot 2021-03-14 at 6 59 36 PM

Here are the relevant sources that confirm the same.

Screen.Recording.2021-03-14.mp4

@jywarren and @harshkhandeparkar, I would like to know if this is the expected behaviour of the algorithm or there is something wrong with my approach so that we can improve upon and add this functionality soon or is there a requirement for such module at all in the first place.

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant